Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Supported Towers capabilities #1487

Open
wwieder opened this issue Sep 16, 2021 · 10 comments
Open

Run Supported Towers capabilities #1487

wwieder opened this issue Sep 16, 2021 · 10 comments
Assignees
Labels
type: enhancement new capability or improved behavior of existing capability

Comments

@wwieder
Copy link
Contributor

wwieder commented Sep 16, 2021

Expand capabilities from run_neon to simulate additional supported tower sites (e.g. PLUMBER2 & AmeriFlux for RUBISCO).

Since we already have surface datasets and datm input for additional tower sites we should be able to build on the run_neon script to automate the generation of spinup, postAD and transient simulations for different tower sites.

From our conversation at the SE meeting it sounds like this could be done by creating the appropriate user_mods directories for each network / tower site and then adding some additional functionality to a more generic run_tower script that facilitates running one or multiple supported tower sites.

@olyson noted that PUMBER has some additional complications because all tower sites:

  • Run with local time, meaning they have to initialize the model at different starting times
  • Span different time periods, length of records
  • Forcing data are at 30 or 60 minute time intervals
  • Use LAI stream files for SP simulations (these have also been created)
    @ekluzek suggested this can all be handled by the user_mod directories.

This issue is closely related to #1354, but has more/ updated specifics

@wwieder wwieder added the tag: enh - new science enhancement that brings in new science capabilities label Sep 16, 2021
@wwieder wwieder added this to To do in Single point via automation Sep 17, 2021
@ekluzek ekluzek added the tag: next this issue should get some attention in the next week or two label Sep 23, 2021
@ekluzek
Copy link
Contributor

ekluzek commented Sep 23, 2021

Adding next to this so that we decide who will be working on this and about when we want this to happen.

@billsacks billsacks added type: enhancement new capability or improved behavior of existing capability and removed tag: next this issue should get some attention in the next week or two labels Sep 23, 2021
@ekluzek ekluzek added the tag: next this issue should get some attention in the next week or two label Jan 9, 2023
@wwieder wwieder added closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix and removed tag: enh - new science enhancement that brings in new science capabilities tag: next this issue should get some attention in the next week or two labels Feb 22, 2023
@wwieder
Copy link
Contributor Author

wwieder commented Feb 22, 2023

I don't see us doing this in the short term, so I'll close this issue for now.

@wwieder wwieder closed this as completed Feb 22, 2023
Single point automation moved this from To do to Done Feb 22, 2023
@wwieder wwieder removed the closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix label Aug 2, 2023
@wwieder wwieder moved this from Done to To do in Single point Aug 2, 2023
@wwieder wwieder reopened this Aug 2, 2023
Single point automation moved this from To do to In progress Aug 2, 2023
@wwieder
Copy link
Contributor Author

wwieder commented Aug 2, 2023

I'm reopening this issue because it seems that we'd like to broaden capabilities of single point runs to include PLUMBER2 sites. This can now build on the subset_data and run_neon capabilities we've already created and can hopefully be extended to this broader set of towers that are being processed through ONEFLUX and evaluated with modelevaluation.org.

@wwieder wwieder added the tag: next this issue should get some attention in the next week or two label Aug 2, 2023
@wwieder
Copy link
Contributor Author

wwieder commented Aug 2, 2023

Assigning Keith and Sam to this for now, as they were in our meeting yesterday, but we should discuss prioritization for this and who's best suited to do the work.

@wwieder wwieder added this to Back Burner (or lower priority) in CTSM-CLM6 development highlights via automation Aug 2, 2023
@wwieder
Copy link
Contributor Author

wwieder commented Aug 3, 2023

@ekluzek noted that we want to bring in testing for this python script. The high level design would to use the same infrastructure to call either NEON or PLUMBER sites.

We can also use this as an opportunity to clean up some of the logic / duplication of features handled by this python script vs. those in usermod_dirs. I'll set up a meeting to work on this code design.

A timeline for this could be to complete this by December 2023.

@billsacks billsacks removed the tag: next this issue should get some attention in the next week or two label Aug 10, 2023
@ekluzek
Copy link
Contributor

ekluzek commented Sep 6, 2023

This is part of the work the team will be doing in our hackathon to get this going for tower sites.

Myself and the following...

@adrifoster
@olyson
@slevis-lmwg
@TeaganKing
@wwieder

@slevis-lmwg
Copy link
Contributor

Corresponding notes in this google doc.

@ekluzek
Copy link
Contributor

ekluzek commented Sep 7, 2023

One thing we decided today is that we'll add an additional recognized option to CLM_USRDAT_NAME for PLUMBER2. The NEON options also have a NEONSITE XML variable for it's list of sites, similarly there will be a PLUMBER2SITE XML variable for the PLUMBER2 list of sites.

@wwieder wwieder moved this from Back Burner (or lower priority) to On the grill (work in progress) in CTSM-CLM6 development highlights Sep 12, 2023
@wwieder
Copy link
Contributor Author

wwieder commented Oct 26, 2023

This seems to be subsumed in these two tower site PRs

#2186
#2155

@TeaganKing
Copy link
Contributor

As PR #2135 is about to be merged in, I wanted to make sure we document the expected changes in a future PR to run supported towers capabilities:

  • Build abstract TowerSite class
  • Generic class
  • Add NEON class with NEON-specific behavior
  • Create new methods and unit tests
  • Add PLUMBER class and behaviors
  • Integration testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement new capability or improved behavior of existing capability
Projects
Status: On the grill (work in progress)
CTSM-CLM6 development highlights
  
On the grill (work in progress)
Single point
In progress
Development

No branches or pull requests

10 participants