-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does release-clm5.0.12 need to be moved to master? #873
Comments
I'm not completely sure about this one. But, I need to do some study on the issue to figure it out. I will do that and report back. |
OK, so this does a couple of different things, some of which it turns out should come in. It adds the handling of 2010 compsets, which should come in because there are a few 2010 compsets in CAM for cesm2.1.2. It has better handling of picking of initial conditions, so that logic should come in as well. The thing I'm not sure about is that it changes initial condition files. |
And the fix for #550 , which I assume should come in. |
Yes, that would come in. I looked at the IC files and master has newer IC files than the ones on the release branch (and newer than the ones updated to in "12" as well). So I think most everything comes in other than the updated IC files. Presumably, that's what I was thinking when I excluded "12" from the list, these are new IC files that should only be used on the release branch. But, the rest of the changes do apply and should come in. |
Resolved. |
@ekluzek - in the card for moving release changes to master (https://github.com/ESCOMP/CTSM/projects/6#card-13680676), you don't mention needing to move release-clm5.0.12 to master. But it looks like at least the fix for #550 is on the release branch but not on master, which makes me wonder if there are other changes that came into release-clm5.0.12 but not to master.
The text was updated successfully, but these errors were encountered: