Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update out-of-the-box initial conditions files by running them through init_interp #312

Closed
billsacks opened this issue Mar 5, 2018 · 5 comments
Closed

Update out-of-the-box initial conditions files by running them through init_interp #312

billsacks opened this issue Mar 5, 2018 · 5 comments
Assignees
@billsacks
Labels
type: enhancement new capability or improved behavior of existing capability

Comments

@billsacks
Copy link
Member

With the changes in #311 , out-of-the-box initial conditions files are incompatible with the memory allocation, so use_init_interp always needs to be true. This should be okay for now, but we can get a speedup in initialization by pointing to already-interp'ed initial conditions files. (This will clearly give a speedup for cases where we no longer need to use init_interp, but I think it will also give a speedup when we need init_interp, because new restart files are about 1/3 the size of old ones.)

In talking about this with @ekluzek , we decided that I probably shouldn't do this interpolation as part of #311 . The main reason is that I want #311 to be bit-for-bit. When we do the interpolation, we figure we might as well move to a gx1v7 mask (most initial conditions files still have a gx1v6 mask). I think that making this change in mask could change answers for cases that do an additional interpolation from this file (imagine a lake point near the Caspian Sea: the source point for the interpolation could differ now).

So we feel that the interpolation of initial conditions should happen in a separate tag.
@billsacks billsacks added the type: enhancement new capability or improved behavior of existing capability label Mar 5, 2018
@billsacks
Copy link
Member Author

Note when doing this: the finidat pointed to by the interp_f19_noncrop testmod should also be updated (changing it to interp_f09_noncrop if necessary).

@billsacks billsacks added this to the cesm2 milestone Mar 6, 2018
@billsacks
Copy link
Member Author

Maybe this can be addressed along with #313

@billsacks billsacks mentioned this issue Mar 6, 2018
Closed
@billsacks
Copy link
Member Author

We may or may not do this for the cesm2 release, depending on time.

@billsacks billsacks added this to To do in Upcoming tags via automation Apr 30, 2018
@ekluzek ekluzek modified the milestones: cesm2, cmip6 May 14, 2018
@ekluzek
Copy link
Contributor

ekluzek commented May 14, 2018

I'm pretty sure we said we'd do this for cmip6 now.

@billsacks billsacks removed this from the cmip6 milestone Nov 5, 2018
@billsacks
Copy link
Member Author

We'll still do this on master, but not on the release branch

@billsacks billsacks self-assigned this Jan 11, 2019
billsacks added a commit to billsacks/ctsm that referenced this issue Jan 12, 2019
@billsacks
Point to new, interpolated initial conditions files
42b2b49 
These use the more limited memory allocation that was implemented about
a year ago, as well as updating the mask from gx1v6 to gx1v7. These
files were generated by taking the finidat_interp_dest.nc file from
appropriate cases, using ctsm1.0.dev022.

Resolves ESCOMP#312
@billsacks billsacks mentioned this issue Jan 18, 2019
Merged
@billsacks billsacks removed this from To do in Upcoming tags Feb 26, 2019
billsacks added a commit that referenced this issue Feb 26, 2019
@billsacks
Merge branch 'remove_expensive_tests'
b6981ad 
Interpolate out-of-the-box initial conditions and remove expensive tests

Two main changes (plus some small additional changes):

1. Removed / reworked some expensive tests

2. Interpolated all out-of-the-box initial conditions, so that the
   out-of-the-box version is now compatible with our current
   configuration. The changes from before were (a) our standard
   configuration now uses the gx1v7 rather than gx1v6 land mask; (b)
   many inactive points are now absent in memory.

See #622 for details.

- Resolves #312
- Partially addresses #275 (just a bit)
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this issue Feb 26, 2019
@slevis-lmwg
Merge tag 'ctsm1.0.dev028' into n_dom_landunits
5cedfe0 
Interpolate out-of-the-box initial conditions and remove expensive tests

Two main changes (plus some small additional changes):

1. Removed / reworked some expensive tests

2. Interpolated all out-of-the-box initial conditions, so that the
   out-of-the-box version is now compatible with our current
   configuration. The changes from before were (a) our standard
   configuration now uses the gx1v7 rather than gx1v6 land mask; (b)
   many inactive points are now absent in memory.

See ESCOMP#622 for details.

- Resolves ESCOMP#312
- Partially addresses ESCOMP#275 (just a bit)

Conflicts resolved:
	doc/ChangeLog
	doc/ChangeSum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billsacks billsacks

Labels
type: enhancement new capability or improved behavior of existing capability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@billsacks @ekluzek