-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compset matches in driver's config_component should be made more general #119
Comments
Many of the compset matches in driver_cpl/cime_config/config_component.xml seem fragile, especially if we want this same file to work for a variety of active components. Examples are the various NCPL settings and CPL_SEQ_OPTION. It feels like there references here to specific component names should mostly be eliminated (although it looks like they may be needed in some cases - e.g., to distinguish between the desired coupling frequency of POP vs. MPAS). I'm not sure what would be the best way to solve this problem, but one idea is to have variables like LND_COMP_TYPE saying whether (for example) the land model is active, data, stub or coupler_test - and same for OCN, ATM, GLC, ICE, etc. Then buggy(?) rules like this (for OCN_NCPL):
could be written as ATM_COMP_TYPE="data" LND_COMP_TYPE="active" ICE_COMP_TYPE="stub" OCN_COMP_TYPE="stub" |
Things like this also concern me (for CCSM_BGC):
What if someone introduces a new DATM mode? It's so easy to miss the fact that you need to update the driver's config_component for things like this. I often wish that we didn't have the ability to have regular expression matches against compset at all in these xml files, but instead required that components set various pieces of metadata that could be queried for these purposes. |
In talking this through with @mvertens, we feel that there are a few things going on here that should be addressed at some point. This isn't critical, but will be important to address if we want the driver to be more component-independent:
|
There are similar compset matches in config_pes.xml and config_grids.xml - and maybe elsewhere - which should also be handled similarly. |
This should not have been closed: I believe that the commit that references this issue number was referring to CESM-Development#119 -- not this issue |
For some more examples and thinking around this issue, see #1522 (comment) and #1522 (comment) and some follow-on comments in that issue |
I was assigned this issue to look back and decide if it should still be done. I do still feel this is important, so I'd like to keep it open. |
Yet again, the fragile regular expression matches on compset are causing problems and slowing us down (for example, see the change I needed to make in ESCOMP/CESM_CICE5@ac908ac) |
Moving issue CESM-Development#402 to here, in the comments that follow.
The text was updated successfully, but these errors were encountered: