Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyDataType in Criterion 30: SC-GENERAl_AVERAGE_TURNOVER #265

Closed
lbota opened this issue Apr 2, 2020 · 2 comments
Closed

PropertyDataType in Criterion 30: SC-GENERAl_AVERAGE_TURNOVER #265

lbota opened this issue Apr 2, 2020 · 2 comments
Labels
V3.0.0 A solution for the issue is to be provided in version 3

Comments

@lbota
Copy link

lbota commented Apr 2, 2020

Dear ESPD team,

During the development of SEMIC we have found that in Criterion 30 of both Basic and Extended taxonomies the QUESTION/REQUIREMENT “Number of fiscal years” data types were changed to QUANTITY_INTEGER from AMOUNT in the latest ESPD version. While this change is much a better fit for it, we would like to propose to refine even more the data type by using QUANTITY_YEAR, that is already present in ESPD’s CL.

The QUESTION_GROUP/REQUIREMENT_GROUP we are referring to are:

  • Basic: e1886054-ada4-473c-9afc-2fde82c24cf4
  • Extended: 53882893-f4a8-40ae-99dc-cad7b0748790

Please note that in the latter, the REQUIREMENT_GROUP is wrongly closed, as cardinality, UUID and ElementCode are present at element closure, but the closing bracket “}” is missing:

issue

We hope you find these remarks useful.

Kind regards,
SEMIC team

@AFSOLUZIONI
Copy link

Hi,
you're right!
In my analisys of 2.1.1 extended I found the same remarks,
Francesco

@hricolor hricolor added the V3.0.0 A solution for the issue is to be provided in version 3 label Apr 14, 2020
@hricolor
Copy link
Collaborator

After carrying out the analysis and present in the OUC meeting (Wednesday 17 of June), for this issue the PropertyDataType will be changed from QUANTITY_INTEGER to QUANTITY_YEAR, to better represent the content expected for "Number of fiscal years". Also, the errors found in the Criteria Taxonomy will be corrected.

This issue will be fixed in the new version of ESPD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3.0.0 A solution for the issue is to be provided in version 3
Projects
None yet
Development

No branches or pull requests

3 participants