I2C BME280 & TSL2561 support + two I2C buses #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShonP40
changed the title
|
Nice! |
|
I feel like trying to support all the worlds sensors could compromise the main mission of ESPresense. Maybe we can these all optional kinda like how tasmota has a full and a minimal? |
Maybe it'll be better to merge this PR first and then I'll start implementing that system in a separate PR? |
|
Ok the sensors builds are ready. Just make sure all your code is in the #ifdef SENSORS |
|
Alright, added it and merged your commits |
DTTerastar
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the I2C version of the BME280 and TSL2561 sensors as well as support for two I2C buses.
More info: