Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC20 tokens balances #1015

Merged
merged 18 commits into from Sep 21, 2019
Merged

ERC20 tokens balances #1015

merged 18 commits into from Sep 21, 2019

Conversation

gagarin55
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #1015 into master will decrease coverage by 0.01%.
The diff coverage is 5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
- Coverage   37.57%   37.56%   -0.02%     
==========================================
  Files         293      294       +1     
  Lines        4695     4699       +4     
  Branches      639      639              
==========================================
+ Hits         1764     1765       +1     
- Misses       2737     2747      +10     
+ Partials      194      187       -7
Impacted Files Coverage Δ
...s/MultiCreateTransaction/MultiCreateTransaction.js 0% <ø> (ø) ⬆️
packages/react-app/src/index.ts 0% <0%> (ø) ⬆️
packages/react-app/src/tx/TxDetails/index.ts 0% <0%> (ø)
packages/react-app/src/tx/TxDetails/TxDetails.tsx 0% <0%> (ø)
packages/desktop/src/containers/Screen/screen.js 0% <0%> (ø) ⬆️
...kages/ui/src/components/tx/TxDetails/TxDetails.tsx 70% <33.33%> (-2.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ef388...e3425e7. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #1015 into master will decrease coverage by 0.28%.
The diff coverage is 44.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
- Coverage   37.57%   37.29%   -0.29%     
==========================================
  Files         293      304      +11     
  Lines        4695     4851     +156     
  Branches      639      667      +28     
==========================================
+ Hits         1764     1809      +45     
- Misses       2737     2869     +132     
+ Partials      194      173      -21
Impacted Files Coverage Δ
...ages/desktop/src/store/launcher/launcherActions.js 3.12% <ø> (+0.18%) ⬆️
...ackages/ui/src/components/common/CoinIcon/index.ts 0% <ø> (ø) ⬆️
...kages/ui/src/components/common/InlineEdit/index.ts 0% <ø> (ø) ⬆️
packages/core/src/Units.ts 100% <ø> (ø) ⬆️
...ponents/ledger/ImportAccount/AddressList/styles.ts 100% <ø> (ø) ⬆️
packages/store/src/txhistory/types.ts 100% <ø> (ø) ⬆️
packages/erc20/src/abi.ts 100% <ø> (ø) ⬆️
...sktop/src/store/wallet/settings/settingsActions.js 5.88% <ø> (+1.12%) ⬆️
...kages/react-app/src/import/ImportMnemonic/index.ts 0% <ø> (ø)
packages/desktop/src/lib/deployedTokens.js 100% <ø> (ø) ⬆️
... and 221 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ef388...68a652b. Read the comment docs.

@gagarin55 gagarin55 changed the title problem: incorrect coin ticker on tx details page ERC20 tokens sending Sep 19, 2019
@gagarin55 gagarin55 added the WIP Work in progress label Sep 19, 2019
@gagarin55 gagarin55 changed the title ERC20 tokens sending ERC20 tokens balances Sep 21, 2019
@gagarin55 gagarin55 removed the WIP Work in progress label Sep 21, 2019
@gagarin55 gagarin55 merged commit d15e554 into emeraldpay:master Sep 21, 2019
@gagarin55 gagarin55 deleted the erc20 branch October 15, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant