Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: tx history doesnt show token values #651

Merged
merged 1 commit into from Jun 22, 2018

Conversation

shanejonas
Copy link
Contributor

@shanejonas shanejonas commented Jun 22, 2018

Solution: show token value of sent txes

fixes #644

image

@ghost ghost assigned shanejonas Jun 22, 2018
@ghost ghost added the review label Jun 22, 2018
Solution: show token value of sent txes
@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #651 into master will increase coverage by 0.04%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
+ Coverage   25.98%   26.02%   +0.04%     
==========================================
  Files         155      155              
  Lines        2925     2939      +14     
  Branches      385      388       +3     
==========================================
+ Hits          760      765       +5     
- Misses       1946     1953       +7     
- Partials      219      221       +2
Impacted Files Coverage Δ
src/store/vault/tokens/tokenActions.js 7.01% <ø> (ø) ⬆️
src/components/tx/TxHistory/List/transaction.js 0% <0%> (ø) ⬆️
src/components/tx/TxHistory/List/TxView.js 65.71% <42.85%> (-16.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c8e8f...ec2450e. Read the comment docs.

@shanejonas shanejonas merged commit 35d20d6 into emeraldpay:master Jun 22, 2018
@ghost ghost removed the review label Jun 22, 2018
@shanejonas shanejonas deleted the fix/token-history branch June 22, 2018 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Which branch is the latest stable version of the wallet?
2 participants