Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Character::NotificationTexts endpoint #61

Open
amclain opened this issue Sep 4, 2016 · 2 comments
Open

Implement Character::NotificationTexts endpoint #61

amclain opened this issue Sep 4, 2016 · 2 comments
Labels

Comments

@amclain
Copy link
Contributor

amclain commented Sep 4, 2016

The scope of this issue is to implement the Character::NotificationTexts endpoint.

@amclain amclain added the feature label Sep 4, 2016
@amclain amclain self-assigned this Nov 21, 2016
@amclain
Copy link
Contributor Author

amclain commented Nov 22, 2016

This endpoint has a CDATA section that needs to be coerced. The CDATA params change based on the type of message.

<rowset name="notifications" key="notificationID" columns="notificationID">
  <row notificationID="589251502">
    <![CDATA[amount: 43188
billTypeID: 2
creditorID: 1000033
currentDate: 131241741999174933
debtorID: 98063277
dueDate: 131267637960000000
externalID: 27
externalID2: 60003652
]]>
  </row>
</rowset>

@amclain amclain removed their assignment Dec 1, 2016
@amclain
Copy link
Contributor Author

amclain commented Dec 1, 2016

This problem may be solvable with the :hash type, which is being introduced in PR #159. Although it won't coerce the individual values (it may be impractical to coerce every possible type of CDATA), it can structure the CDATA element as a Ruby hash so the user can sort through the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant