Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EvseV2G: complete migration to libevse-security #532

Open
barsnick opened this issue Feb 7, 2024 · 1 comment
Open

EvseV2G: complete migration to libevse-security #532

barsnick opened this issue Feb 7, 2024 · 1 comment

Comments

@barsnick
Copy link
Contributor

barsnick commented Feb 7, 2024

In commits 138b9db and dda60db, the EvseV2G module was converted to use libevse-security to locate the TLS certificates.

Yet there are still certificate paths for PnC which are (hard-) coded within the source code, e.g. here:

std::string v2g_root_cert_path = conn->ctx->certs_path + "/ca/v2g/V2G_ROOT_CA.pem";
std::string mo_root_cert_path = conn->ctx->certs_path + "/ca/mo/MO_ROOT_CA.pem";

For consistency, EvseV2G should be converted to use libevse-security here.

Additionally, EvseV2G could use libevse-security to verify client certificates (etc.), instead of using its own code. (Stage 2, nice to have.)

@corneliusclaussen
Copy link
Contributor

I think that is something we also found at the cleveland testival, we tried something like this:

  •        std::string v2g_root_cert_path = conn->ctx->r_security->call_get_verify_file(types::evse_security::CaCertificateType::V2G);
    
  •        std::string mo_root_cert_path = conn->ctx->r_security->call_get_verify_file(types::evse_security::CaCertificateType::MO);
    
  •        std::string v2g_root_cert_path = conn->ctx->certs_path + "/ca/v2g/V2G_ROOT_CA.pem";
    
  •        std::string mo_root_cert_path = conn->ctx->certs_path + "/ca/mo/MO_ROOT_CA.pem";
    

However I think the CertificateTypes we are requesting are wrong in this example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants