Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EvseV2G: Integration of libcbv2g as OpenV2G replacement #544

Open
8 tasks
SebaLukas opened this issue Feb 13, 2024 · 4 comments
Open
8 tasks

EvseV2G: Integration of libcbv2g as OpenV2G replacement #544

SebaLukas opened this issue Feb 13, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SebaLukas
Copy link
Contributor

Currently the EvseV2G module uses the OpenV2G project to encode and decode EXI messages.
The goal now is to replace OpenV2G with the new libcbv2g library.

The libcbv2g contains the generated c EXI code from the cbexigen generator with a CMake integration.

Tasks:

  • dependencies.yaml + module-dependencies.cmake: replace openv2g with libcbv2g
  • EvseV2G module: Customize CMakeLists.txt
  • EvseV2G module: Customize include headers
  • EvseV2G module: Customize src code
  • DIN70121 is working
  • ISO15118-2 AC EIM is working
  • ISO15118-2 DC EIM is working
  • ISO15118-2 PnC is working

Every contribution is appreciated 😃

@SebaLukas SebaLukas added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 13, 2024
@SiebrenW
Copy link

I am somewhat prepared to work on this a bit in my free time.
I have no facilities to test this though, besides unit tests and such.

@SebaLukas
Copy link
Contributor Author

That's great 👍 For now, it would be enough if everest-core (EvseV2G module with libcbv2g) builds without errors and warnings. DIN70121 would also be the "easiest" to start with, as PnC is not possible here.
You can use the various SILs for testing.

If you need any help, let me know.

@SiebrenW
Copy link

SiebrenW commented Feb 23, 2024

As mentioned in the cbexigen issue, the SignedInfo element must be encoded in another schema, so the fragments in ISO-2 and ISO-20 for SignedInfo are useless.
This is a bit of a blocker for removing OpenV2G altogether (I started with removing it completely, only to notice that this schema was missing). More in issue EVerest/cbexigen#69

@SiebrenW
Copy link

So the previous isn't an issue after all. Apparently cbv2g decided to duplicate the xmldsig fragment encoders for every message namespace, which on one hand is duplicate logic, but on the other simplifies things (just assign the element instead of converting it from one type to the other.

This PR has the initial changes to remove openv2g: #563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants