Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate/Missing IDs when editing in OrthoNormal #322

Closed
berndmoos opened this issue Jun 16, 2022 · 5 comments
Closed

Duplicate/Missing IDs when editing in OrthoNormal #322

berndmoos opened this issue Jun 16, 2022 · 5 comments
Assignees
@berndmoos
Labels
AGD bug OrthoNormal
Milestone
Release 2023

Comments

@berndmoos
Copy link
Collaborator

The method only checks for existing IDs on <w>, must check on all elements with @id
@berndmoos berndmoos self-assigned this Jun 16, 2022
@berndmoos berndmoos added this to the Release 2022 milestone Jun 16, 2022
berndmoos added a commit that referenced this issue Jun 16, 2022
@berndmoos
#322
bb6c77d
berndmoos added a commit that referenced this issue Jun 17, 2022
@berndmoos
#322
74b1c84
@berndmoos
Copy link
Collaborator Author

Done, methinks

@berndmoos
Copy link
Collaborator Author

Under some circumstances, the resulting contribution does not have IDs. This is probably due to an exception which is caught but not displayed or handled. Changed that now so that (1) exceptions are always displayed and (2) changes to the contribution are revoked.

berndmoos added a commit that referenced this issue Apr 17, 2023
@berndmoos
Another fix for #322
0493235
@berndmoos
Copy link
Collaborator Author

The problem persists: Some contributions end up without IDs. Need to reopen this.

@berndmoos berndmoos reopened this Apr 12, 2024
@berndmoos berndmoos changed the title Duplicate IDs when editing in OrthoNormal Duplicate/Missing IDs when editing in OrthoNormal Apr 12, 2024
@berndmoos
Copy link
Collaborator Author

Changed the XPath for selecting IDable elements once more, think it works now.

berndmoos added a commit that referenced this issue Apr 18, 2024
@berndmoos
#322: Fix the bug fix - IDs for explicitly selected elements now
6836fe3
@berndmoos berndmoos added the AGD label Apr 23, 2024
@berndmoos
Copy link
Collaborator Author

FOLK confirmed that it works, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berndmoos berndmoos

Labels
AGD bug OrthoNormal
Projects
None yet
Milestone
Release 2023
Development

No branches or pull requests
1 participant
@berndmoos