Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language pack inheritance order #4

Closed
koenner01 opened this issue Feb 27, 2017 · 2 comments
Closed

Language pack inheritance order #4

koenner01 opened this issue Feb 27, 2017 · 2 comments
Assignees
Labels

Comments

@koenner01
Copy link

Is there a reason why there is no Magento vendor inheritance defined in the language.xml ?
Because currently if we are adding the eadesigndev/ro_ro pack as a parent to our projects pack, the order in packs is:

eadesigndev |ro_RO
Magento|ro_RO
Project|ro_RO

Aren't the translations in this pack supposed to replace the Magento ones ? (because now Magento will replace your packs translations)

@eadesignro eadesignro self-assigned this Feb 27, 2017
@eadesignro
Copy link
Contributor

Can you give us example for the inheritance?

@koenner01
Copy link
Author

@eadesignro If you add a language pack to your project with inheritance to this pack like

<?xml version="1.0"?>
<language xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:App/Language/package.xsd">
    <code>ro_RO</code>
    <vendor>projectname</vendor>
    <package>ro_ro</package>
    <use vendor="eadesigndev" package="ro_ro"/>
</language>

The order in which the translations on the frontend will be done will be

eadesigndev |ro_RO
Magento|ro_RO
Project|ro_RO

So if Magento has a translation for the same line as this pack, the Magento translation will be used!
I assume this pack is supposed to be an improvement to the Magento translations ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants