Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pls support null safe #105

Closed
buimanhhungit opened this issue Mar 26, 2021 · 7 comments · Fixed by #118
Closed

Pls support null safe #105

buimanhhungit opened this issue Mar 26, 2021 · 7 comments · Fixed by #118

Comments

@buimanhhungit
Copy link

No description provided.

@jacojvv-dev
Copy link

See #103

@buimanhhungit
Copy link
Author

image
Not support at here. Pls check again.

@stevenebutler
Copy link
Collaborator

stevenebutler commented Apr 5, 2021

If you want to try the pull request out, you can use the following in your pubspec.yaml

But before you do, be warned that

  • this PR changes the interface to the library a bit (due to the use of the flutter_webview package that works differently to the webview used in the current package).
  • there is no guarantee the maintainers will accept the PR (especially due to the above point).

I'm happy to work with the maintainers to make changes that will still support my objectives of null safety/flutter 2 and mobile/web support though. :)

  aad_oauth:
    git:
      url: https://github.com/stevenebutler/aad_oauth.git
      ref: null-safety

@buimanhhungit
Copy link
Author

Tks.

@stale
Copy link

stale bot commented Jun 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you still think this issue is needed, reopen it again.

@stale stale bot added the stale label Jun 7, 2021
@deanbot
Copy link

deanbot commented Jun 10, 2021

Not stale :) conversation happening in #103 though.

@stevenebutler
Copy link
Collaborator

stevenebutler commented Jul 25, 2021

Following discussion with the maintainers, I have created a new PR that only ports the library to null-safety and makes no API changes to the original aad_oauth.

You can test by using package source below, until it is accepted into the mainline aad_oauth package.

  aad_oauth:
    git:
      url: https://github.com/stevenebutler/aad_oauth.git
      ref: null-safety-only

This version contains no changes to the flutter web plugin, and does NOT support flutter web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants