Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added getCode() method to BaseProvider #126

Merged
merged 11 commits into from May 23, 2022
Merged

✨ Added getCode() method to BaseProvider #126

merged 11 commits into from May 23, 2022

Conversation

arimgibson
Copy link
Contributor

Closes #95

  • Added getCode() method
  • Added test against ethers
  • Added test against web3.js
  • Added test for contracts that don't exist
  • Added inline documentation for getCode()

@arimgibson arimgibson requested a review from dawsbot May 19, 2022 16:38
@vercel
Copy link

vercel bot commented May 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
essential-eth ✅ Ready (Inspect) Visit Preview May 22, 2022 at 6:37PM (UTC)

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #126 (7f5b822) into master (b5c0e24) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   85.80%   85.99%   +0.18%     
==========================================
  Files          37       37              
  Lines         902      907       +5     
  Branches      259      261       +2     
==========================================
+ Hits          774      780       +6     
+ Misses        113      112       -1     
  Partials       15       15              
Impacted Files Coverage Δ
src/classes/utils/fetchers.ts 93.33% <ø> (ø)
src/providers/BaseProvider.ts 100.00% <100.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c0e24...7f5b822. Read the comment docs.

Copy link
Owner

@dawsbot dawsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just BigInt overflow is the only concern to address before merging

@arimgibson
Copy link
Contributor Author

Converting this to a draft temporarily while I work out the bugs from those failing tests. Will be done by tomorrow

@arimgibson
Copy link
Contributor Author

@dawsbot I made those tweaks 😀

@dawsbot dawsbot merged commit 7c230f4 into master May 23, 2022
@dawsbot dawsbot deleted the feature/getCode branch May 23, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add getCode() method to JsonRpcProvider
2 participants