Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it will coredump if senptr > recptr in memmove function in slutils.c #9

Open
wangmm0220 opened this issue Mar 9, 2023 · 1 comment

Comments

@wangmm0220
Copy link

In the branch of develop.

(slconn->stat->slpack.reclen > 0 && slconn->stat->slpack.reclen > bufferlen)) should be (slconn->stat->slpack.reclen > 0 && slconn->stat->slpack.reclen + SLHEADSIZE > bufferlen))

otherwise sendptr will be bigger than recptr
send:1560, rec:1556

@chad-earthscope
Copy link

Thanks @wangmm0220. That should be protected against.

Out of curiosity, have you see this scenario occur? If so, what were the circumstances? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants