-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage with MultiTenancy #12
Comments
Did you mean a host-side admin controlling tenant's setting values? If so, you should not do that, the host is not the master of tenants, please think of it as a tenant without TenantId. |
No, what I mean is tenants themself controlling the setting ontop of users. So the tenant "admins" can control the settings, which will be inherited by the users. So tenant-settings. Example: Tenant A needs background color: #000000 from setting Both which will be applied for all users which are either on Tenant A or Tenant B |
Got it. I think you found a bug. Hi @wakuflair, I try to grant the setting UI's permission to a tenant-side user, when he changes a setting value, his behavior affects the global setting value: The expected result is that a tenant-side setting data is created, is that so? |
As far as I have seen like the comment above from @gdlcf88, the settings are also global for all users, so is this intended, or actual missing stuff or a bug? :D |
Hi guys |
For now, an admin user (from the host or one of the tenants) can grant the setting management permission himself and control the global values. It is dangerous! Tenants and the host should only control the setting values in their own scope. Even a host admin should not be allowed to change the global values since generally the host is not the master of all the tenants. Maybe SettingUI could provide extra permission and page to manage the global setting values. (the permission is tenant-only, of course). But it seems ABP has no way to control the setting values for only the host: abpframework/abp#4368 |
About the user-side setting values management, I have these ideas:
|
After some consideration, I think the global setting management feature is not reasonable to exist. If an app admin wants to manage a global setting value, he can change the default value or implement the global values management feature himself. All in all, we should not provide an unreasonable design. |
Of course he can. But SettingUI is supposed to provide an easy way to set settings value. For example: An admin wants to set the theme of the entire website through UI. |
He can only change the setting value of the current tenant (for the host-side, the TenantId == null), instead of the global setting value. Because nobody has permission to change a global setting value in ABP multi-tenant design. |
Is this way available for single tenant applications? |
I think so, since setting values of single-tenant apps (or we call it host-only apps) will be affected by the setting |
OK. I'll change |
Hi, just started using your module, its awesome!
What is the roadmap for implementing the tenant provider and giving ability to control settings for tenants?
Thanks
The text was updated successfully, but these errors were encountered: