Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy_dir per server #107

Open
BNEP opened this issue Jan 14, 2020 · 2 comments · May be fixed by #124
Open

deploy_dir per server #107

BNEP opened this issue Jan 14, 2020 · 2 comments · May be fixed by #124

Comments

@BNEP
Copy link

BNEP commented Jan 14, 2020

Hello, it would be nice having ther deploy_dir (deployDir) configurable per server because different servers could have different paths to web DocRoot. To get this benefit i made some changes in the code:

src/Deployer/DefaultDeployer.php:188
foreach ($appServers as $server) { $this->log(sprintf('<h3>Setting the %s property for <server>%s</> server</>', Property::deploy_dir, $server)); // BNEP modified: we want to set deploy_dir per server if not set with ->deployDir() if(empty(Property::deploy_dir)){ $server->set(Property::deploy_dir, $this->getConfig(Option::deployDir)); } }
src/Configuration/DefaultConfiguration.php:364
protected function getReservedServerProperties(): array { return [Property::bin_dir, Property::config_dir, Property::console_bin, Property::cache_dir, /* ***BNEP modified: deploy_dir should be possible to set per server *** Property::deploy_dir, */ Property::log_dir, Property::src_dir, Property::templates_dir, Property::web_dir]; }
Maybe you could put that in master?
Regards

@romainjanvier romainjanvier linked a pull request Apr 28, 2021 that will close this issue
@romainjanvier
Copy link

I have the same need and make the PR to add this feature.

Thanks for review.

@four-li
Copy link

four-li commented Aug 27, 2021

+1, I have the same need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants