Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor OSCALLoader #791

Open
tuckerzp opened this issue Apr 21, 2023 · 1 comment
Open

Refactor OSCALLoader #791

tuckerzp opened this issue Apr 21, 2023 · 1 comment
Assignees
@kylelaker
Labels
needs-refinement This task requires additional refinement before it is ready to work

Comments

@tuckerzp
Copy link
Contributor

Description

As a developer on the OSCAL React Library, I want to be able to modularly load and edit components without needing to load an entire document.

Acceptance Criteria

  • Analysis of best approach to refactoring is documented on this issue.
  • The components in the OSCAL react library are no longer as tightly coupled to the OSCALLoader & OSCALLoaderForm.

Proposed Solution

Additional Notes

This should be obvious, but it is important to avoid regressions in our code base. Keep in mind that the OSCALLoader is currently in charge of:

  • All editing functionality
  • Dealing with Errors
  • Loading all json documents
  • Anchor link scrolling
@tuckerzp tuckerzp added the needs-refinement This task requires additional refinement before it is ready to work label Apr 21, 2023
@tuckerzp
Copy link
Contributor Author

Assigning Kyle to help refactor this a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylelaker kylelaker

Labels
needs-refinement This task requires additional refinement before it is ready to work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kylelaker @tuckerzp