Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Brotli #759

Closed
aegis123 opened this issue Aug 29, 2016 · 11 comments
Closed

add support for Brotli #759

aegis123 opened this issue Aug 29, 2016 · 11 comments
Labels
special/external-contrib Issues can be solved by others via PR or EE package.

Comments

@aegis123
Copy link

Maybe add support for the compression algorithm brotli could be added to nginx next to GZIP. Brotli is supposed to offer better compression than gzip especially for static content. Its supported by by both firefox and chrome see caniuse.com and created by Google, they also offer a nginx module ngx_brotli.

@aegis123 aegis123 changed the title add support for brotli add support for Brotli Aug 29, 2016
@renatonascalves
Copy link

Good addition!

@renatonascalves
Copy link

@aegis123
Copy link
Author

also we should keep in mind that the compressing data with brotli is generally slower than gzip but it could off course be cached somewhere.

@EdwardBlack
Copy link

EdwardBlack commented Feb 10, 2017

@aegis123 compressing data with brotli is generally slower

According to google whitepaper, it is even faster (less cpu) then gzip!
I would love an Brotli integration

@MattyLB
Copy link

MattyLB commented Feb 14, 2017

This sounds like a great experimental, enabled per-site addition until we see how it performs!

I'm particularly interested in the code @tlovett1 is working on with PHP7 and Nginx support. The fact that Google is behind it to improve site speed is, of course, another plus! ;)

@rahul286
Copy link
Member

rahul286 commented Jun 2, 2018

We are switching to https://openresty.org/ so adding support for https://github.com/google/ngx_brotli is something we wont be doing anytime soon.

@renatonascalves
Copy link

@rahul286
Copy link
Member

rahul286 commented Jun 3, 2018

@renatonascalves

https://github.com/brandonpapworth/docker-openresty isn't official openresty build. Already no activity on it from a year.

If openresty itself adds support for it, we will consider it.

@RavanH
Copy link
Contributor

RavanH commented Jun 15, 2018

Too bad... hope this request can be moved upstream then :)

@renatonascalves
Copy link

@rahul286 Understood! Totally reasonable. Thank you. :)

@rahul286 rahul286 added special/external-contrib Issues can be solved by others via PR or EE package. and removed release/4.x labels Aug 3, 2018
@rahul286
Copy link
Member

rahul286 commented Aug 3, 2018

We are leaving this to external contributors

@rahul286 rahul286 closed this as completed Aug 3, 2018
@rahul286 rahul286 added this to Done in Feature Requests Aug 3, 2018
@rahul286 rahul286 moved this from Done to New in Feature Requests Aug 3, 2018
@rahul286 rahul286 moved this from New to Done in Feature Requests Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
special/external-contrib Issues can be solved by others via PR or EE package.
Projects
None yet
Development

No branches or pull requests

7 participants