Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CA1852 diagnostic rule #1770

Closed
WeihanLi opened this issue Mar 7, 2024 · 1 comment · Fixed by #1771
Closed

Enable CA1852 diagnostic rule #1770

WeihanLi opened this issue Mar 7, 2024 · 1 comment · Fixed by #1771

Comments

@WeihanLi
Copy link
Contributor

WeihanLi commented Mar 7, 2024

Noticed that there're some internal and private classes are not sealed, maybe we could mark some of them as sealed, see details here: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1852

and we could also add the diagnostic rule in the editorconfig

dotnet_diagnostic.CA1852.severity = warning # Sealed classes
@zidad
Copy link
Member

zidad commented Mar 8, 2024

Sure feel free to make the changes.

@WeihanLi WeihanLi mentioned this issue Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable ca 1852 rule WeihanLi/EasyNetQ
2 participants
@zidad @WeihanLi