New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plans to supports .NET Core? #581
Comments
Hi, I don't think it's planned at the moment, but most likely after the RTM (but PR's welcome of course :)). The RabbitMQ.Client only started to support it yesterday: rabbitmq/rabbitmq-dotnet-client#148 |
Thank you. |
There was a fork that I have had working with dnxcore50 https://github.com/SapientGuardian/EasyNetQ Now that netcore1.0 is supported in the Master branch of RabbitMQ.Client, rabbitmq/rabbitmq-dotnet-client#148 and available in the pre-release feed, I am going to try compiling that fork against netcore1.0 this week if I can find the time. I am also very very keen to see EasyNetQ support for netcore, our current system uses RabbitMQ at it's core with mono services on linux, so I am looking forward to getting a good netcore service running so I can compare it with our mono ones. |
@radicalgeek Great thanks a lot! Is there anything I can do? |
ummmm....Other than put serialisable support back into netcore! No, it's not going bad, I only have 12 errors left. With a bit of hacking it won't be hard to make it work, getting it into any kind of state worthy of a pull request is another matter. |
@radicalgeek You mean the [Serializable] attribute? I don't think it's required/being used, and if it is, it probably shouldn't! I would vote for removing it from the code base completely. @micdenny @Pliner agree? |
The attribute Serializable is in netcore: https://github.com/dotnet/corefx/blob/53204dc13d67e8266a0e9b88845d13220a69afda/src/System.Runtime.Serialization.Formatters/src/System/SerializableAttribute.cs I don't know why was used, probably is not need it as @zidad suggested. |
Here's a PR for removing [Serializable] #587 |
@micdenny I read this regarding Serializable https://github.com/dotnet/corefx/issues/6564 I have 4 weird errors left, telling me that BasicPublish dosn't take 6 params. It clearly dose, and the editor is not giving me the error, only the compiler. Pretty close though. It works when I edit to call the overload that doesn't take the immediate flag. |
ok, I have it compiling on my fork (of a fork, so no idea how behind it is). You can find it here https://github.com/radicalgeek/EasyNetQ . Last time I did this a couple of months ago core dnxcore50 I ended up having to mess around trying to remove the space from the package name before I could get another project to reference it. All I have done is update the packages, and change the call to BasicPublish in RabbitAdvancedBus to remove the immediate flag. So it now calls the overload with 5 params. |
Hi guys,
thanks a lot,
Kevin Yang
The text was updated successfully, but these errors were encountered: