Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project importing and event page #78

Merged
merged 7 commits into from Apr 29, 2016
Merged

Conversation

Zegeri
Copy link
Member

@Zegeri Zegeri commented Apr 28, 2016

  • I propose dropping support for Qt4 builds. In fact, the current editor won't compile with Qt4 since 2014 because we use some Qt5-only modules like QMediaPlayer (884da67).
  • The commands of the event page should look now more familiar to the usual RPG Maker user.

captura de pantalla_2016-04-28_20-22-04

This is how it currently looks like this. There are still some missing commands related to battle and the commands introduced by RPG2k3 1.11.

  • To fix the issue of XYZ images of existing RPG Maker projects, we have two options, add support for XYZ reading on the go or convert them once when importing files. I've decided to go the latter way because it's much easier. Full XYZ support could be added in the future.
    captura de pantalla_2016-04-28_23-22-22
  • Not many RPG Maker users will be interested in the line number of some event command, but it's useful for EasyRPG Player developpers to debug some games.
    captura de pantalla_2016-04-28_23-40-11

@Zegeri
Copy link
Member Author

Zegeri commented Apr 28, 2016

I found some issues, please, don't merge yet.

@Ghabry
Copy link
Member

Ghabry commented Apr 29, 2016

Awesome, 100 👍 for you. I have a reason now to revive the Editor (PR) builder for Windows :D.

The Windows project part is horribly outdated and will never compile this way. Will also open a PR later to fix this.

@Zegeri
Copy link
Member Author

Zegeri commented Apr 29, 2016

Issues resolved and rebased to the upstream HEAD.

@Ghabry
Copy link
Member

Ghabry commented Apr 29, 2016

Teleport parses wrong
unbenannt

@Ghabry Ghabry merged commit 77681fc into EasyRPG:master Apr 29, 2016
@MarianoGnu
Copy link
Member

Great work, but i want to know, what file is the "Line: 441" tooltip refered to?

@Zegeri
Copy link
Member Author

Zegeri commented May 1, 2016

It's its index in the list of command of the current event page. I added it for debugging purposes.

@Ghabry Ghabry added this to the 0.1 milestone Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants