improve vhf/free-programming-books-lint

[borgified]

https://github.com/vhf/free-programming-books-lint/blob/master/dist/lint.js#L10

it appears the linter only considers these "languages". we want to expand the list to include other languages/files as well. eg. Vietnamese, C, Java, SQL lists.

looks like https://github.com/vhf/free-programming-books-lint/blob/master/dist/lint.js#L12 determines what language a particular file is, ie. just based on a part of its filename. maybe its possible to expand that list to include vietnamese since that’s not in the first array of langs. (expecting vn)

in our case, free-courses-vi.md maybe it should be vn instead to conform to ISO 3166

[contributor13]

I would like to fix this issue. Can anyone please suggest what should I do exactly.

[eshellman]

@borgified 'vi' is the correct language code (ISO 639-1); ISO 3166 are country codes.
@contributor13 take a look at https://github.com/vhf/free-programming-books-lint/blob/master/dist/lint.js#L12 and figure out what needs fixing.

[kadhirash]

What I came to notice and my understanding is that from the linter code, it excludes the following files: 'README.md', 'CONTRIBUTING.md', 'CODE_OF_CONDUCT.md', 'SUMMARY.md'

That's why the alphabetization isn't enforced for the above files, but it is for "CODE_OF_CONDUCT-es.md" as seen in #5117.

The langstoAlphabetize var doesn't include 'th' so the Thai resources won't be checked for alphabetization as seen in #3287.

The other languages added to the repository but not updated to the langsToAlphabetize var won't be alphabetized, such as Thai(th), Farsi(fa_IR), Tamil(ta), etc.

A temporary solution could be to just keep adding the ISO 639-1 codes for languages whenever a certain language file is added to the langsToAlphabetize var.

[eshellman]

@computamike has contributed a nice fix for pipes to https://github.com/vhf/free-programming-books-lint/ I've created 3 issues there to address the problems noted in this issue. Folks with Node experience should find these issues pretty easy to fix.

[eshellman]

The most recent PR #5207 seems to have missed an alphabetization error - have we messed up the linter by moving the lists into directories?

[davorpa]

@computamike has contributed a nice fix for pipes to https://github.com/vhf/free-programming-books-lint/ I've created 3 issues there to address the problems noted in this issue. Folks with Node experience should find these issues pretty easy to fix.

The most recent PR #5207 seems to have missed an alphabetization error - have we messed up the linter by moving the lists into directories?

🎉 It seems all merged/resolved:

• fix: better lang detection and more languages #14 vhf/free-programming-books-lint#23 languages that aren't linted vhf/free-programming-books-lint#14
• Fix fpb-lint check lists alphabetical order of non alphabetical language pages #4 vhf/free-programming-books-lint#5 fpb-lint check lists alphabetical order of non alphabetical language pages vhf/free-programming-books-lint#4
• Adding no-pipes-in-links linter vhf/free-programming-books-lint#13 Bug / Idea.... Pipe breaks links vhf/free-programming-books-lint#12 URGENT v 2.2.0 breaks build vhf/free-programming-books-lint#15
• need more flexible exclude vhf/free-programming-books-lint#16 fix: CI linter config #5239
• files in directories aren't checked vhf/free-programming-books-lint#17 fix: CI linter config #5239

[eshellman]

Thanks for checking!