Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Danish full ICU code is da-dk not dk #6908

Closed
davorpa opened this issue Jul 10, 2022 · 1 comment · Fixed by #6909
Closed

Danish full ICU code is da-dk not dk #6908

davorpa opened this issue Jul 10, 2022 · 1 comment · Fixed by #6909
Labels
PR requested Issues that can be addressed with a new PR 🗣️ locale:da Resources addressing "Danish / dansk" language 🗣️ translations Issues or PRs addresing translations

Comments

@davorpa
Copy link
Member

davorpa commented Jul 10, 2022

Danish full ICU code is da-dk

https://www.localeplanet.com/icu/da-DK/index.html

so files should be renamed from *-dk to *-da

Originally posted by @davorpa in EbookFoundation/free-programming-books-search#29 (comment)
@davorpa davorpa added the PR requested Issues that can be addressed with a new PR label Jul 10, 2022
@eshellman
Copy link
Collaborator

I'll do it

@eshellman eshellman mentioned this issue Jul 11, 2022
Merged
@davorpa davorpa added 🗣️ translations Issues or PRs addresing translations 🗣️ locale:da Resources addressing "Danish / dansk" language labels Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR requested Issues that can be addressed with a new PR 🗣️ locale:da Resources addressing "Danish / dansk" language 🗣️ translations Issues or PRs addresing translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use danish lang code, not country. fixes #6908 EbookFoundation/free-programming-books
2 participants
@eshellman @davorpa