Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS support: Graphic thread + Input/Window Event thread #1

Open
Ecconia opened this issue Jun 6, 2020 · 1 comment
Open

MacOS support: Graphic thread + Input/Window Event thread #1

Ecconia opened this issue Jun 6, 2020 · 1 comment

Comments

@Ecconia
Copy link
Owner

Ecconia commented Jun 6, 2020

MacOS throws a bunch of errors when trying to start it. Cause of windows being generated on some other thread. But when I move a bunch of these things over, I might get issues on windows.
-> I lack a testing device to improve the macOS support. If one of you has a mac, feel free to help.

@Ecconia
Copy link
Owner Author

Ecconia commented Jul 30, 2020

Current state:
I currently have one thread for rendering and another one for window/input events.
I do this to reduce input-handling lags. If the FPS are too low for the inputs to be processed, the user (me) gets frustrated. See Minecraft for example. You cannot use commands to stop some lag origin, cause your client lags too much - yay. No go!

Issue:
From what I learned MacOS requires graphic and inputs to be processed on the main thread.
They do this to prevent developers from not handling the input thread, and thus enforcing a better user experience (since the input will always be handled).
So their enforced better user experience, would worsen the user experience of this project.

Action:
I will not take any action. There is currently exactly no MacOS user interested in the project. And changing the current input system to use one thread, is below my minimum acceptance level (level Minecraft).

If you know that I am wrong, and there is a way to use two different threads - please tell me how to do it, so that we can add MacOS support.

You are also free to do the code change to use one thread yourself and PR it, as long as there is a toggle for it. (Warning its a very simple process).

@Ecconia Ecconia changed the title Generic MacOS support MacOS support: Graphic thread + Input/Window Event thread Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant