Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for change startAngle #1

Merged
merged 3 commits into from Apr 5, 2015
Merged

Conversation

hildert
Copy link
Contributor

@hildert hildert commented Apr 3, 2015

This library works really cool and saved my time,thanks for you work :).
I am using it in my project. But I found the start angle can't be changed. so I made the change to the start angle.
Please review the code. Hopefully it could be helpful.

@Eclair
Copy link
Owner

Eclair commented Apr 3, 2015

Hi @hildert, thank you! I was planning to made it in future, and that's why I defined and used "StartAngle" constant in all calculations. I've tested your changes and it looks cool, all works like a charm! Can you please only replace property usage from self.startAngle to _startAngle inside the class? Just to keep it strict, so there will be no mistakes with place where are you using it.

After that I'll make an v0.11 and update cocoa pods.

Thanks

@hildert
Copy link
Contributor Author

hildert commented Apr 4, 2015

Hi @Eclair,thanks for you review :). I have changed all self.startAngle to _startAngle, and I have tested it. Thanks

Eclair added a commit that referenced this pull request Apr 5, 2015
Add support for change startAngle
@Eclair Eclair merged commit b664d6c into Eclair:master Apr 5, 2015
@Eclair
Copy link
Owner

Eclair commented Apr 5, 2015

@hildert Thank you for your contribution. I pushed new version (0.11) to the cocoapods, and it will be available soon! http://cocoapods.org/pods/CircleProgressBar

@hildert
Copy link
Contributor Author

hildert commented Apr 5, 2015

@Eclair You are welcome! It's my first time send a pull request. I learnd so much from your code and code style. Thank you again : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants