Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits trimmed from latest release #39

Closed
K4sum1 opened this issue Mar 29, 2024 · 8 comments
Closed

Commits trimmed from latest release #39

K4sum1 opened this issue Mar 29, 2024 · 8 comments

Comments

@K4sum1
Copy link
Member

K4sum1 commented Mar 29, 2024

These commits weren't reverted for the latest 124 release. They seem to do nothing, and therefore weren't reverted to simplify the update process. If you encounter an issue and one of these seem to be related, please let me know.

a43de70 There is no need for this code to run on pre-10, but it also doesn't affect anything.
83b2866 Profiler isn't very likely to be used, and stub shouldn't be an issue. I haven't seen this break anything in testing.
44c2dea defaultagent shouldn't have any reason to show notifications anyways, doesn't seem to break anything.
8a6d9a4 Parental controls sucks. The code for this should just be stripped out entirely.
5b8d928 Also parental controls.
a5e6f6c Not sure where you would even see this, doesn't seem to effect anything.
5647f7c Supposedly only a issue pre-7 which the extended kernels already have.
9ade047 Chromium Edge can run on 7, idk why there's a version check here.
26001e8 r3dfox assumes he user has VC++ installed and therefore d3dcompiler_47.dll in system even on 7. Also d3dcompiler_46.dll is no longer shipped, so not needed.
26b46fe This seems to only be an issue for XP where TLS 1.2 isn't a thing. Since crash reports won't be going to Mozilla and if I want to make crashreporter useful I can just have it go over http to my own server, it's not a concern.
65a2fe6 Dependency on a below commit that I didn't revert, so not a issue.

These were partially reverted:

c5739e2 Only AvailableMemoryTracker.cpp was reverted. the nsXPCOMGlue changes don't have any effect here since r3dfox assumes the user has VC++ installed and it doesn't ship with Universal CRT DLLs.
31e3d8a The two MenuTouchModeObserver version checks seem to be a non-issue since they were later made available to all operating systems. I assume since it's allowed for macOS and Linux it will work on 7 too. However I can't test. aboutSupport.js security software stuffs seem weird, I'm not sure why 7 wouldn't support it, but even if not it's just blank and a minor visual bug.
bcd7d26 AboutWelcome stuff not reverted since unused in r3dfox,

@adeii
Copy link

adeii commented Apr 7, 2024

Commits that effect on browser/omni.ja caused problem and forced close browser.
Older version of omni.ja/defaults/settings/* and omni.ja/moduls/*.mjs works fine on Win 7. Also 124.0.3 works fine.

@K4sum1
Copy link
Member Author

K4sum1 commented Apr 7, 2024

Commits that effect on browser/omni.ja caused problem and forced close browser. Older version of omni.ja/defaults/settings/* and omni.ja/moduls/*.mjs works fine on Win 7. Also 124.0.3 works fine.

What do you mean by this? What is broken?

@adeii
Copy link

adeii commented Apr 7, 2024

I don't know exactly to tell. Librewolf 124.0.1 got the same problem with force close after 90 sec.
So I had changed all libs from your R3dfox 124.0.3 and still got problem.
So after copying only browser/omni.ja to original Librewolf 124, it runs normal even after 3 minutes.
So, some trimmed commits from gecko-dev, solved problem with force close in R3dfox 124.0.3 !
But that problem was also in R3dfox 124.0.2 32bit.

@K4sum1
Copy link
Member Author

K4sum1 commented Apr 7, 2024

Oh, the force close is because you have an old profile. Is browser.taskbar.lists.legacyBackend set to false in r3dfox? If so, you might need to edit your user.js to set it to true.

@adeii
Copy link

adeii commented Apr 7, 2024

I got force close even on deleting all profiles in AppData/Local, and in portable versions, too.
Thanks for info. Is it could also be set to true via about:config?

@K4sum1
Copy link
Member Author

K4sum1 commented Apr 7, 2024

No, it always crashes if you try setting it to true that way.

@K4sum1
Copy link
Member Author

K4sum1 commented May 14, 2024

Seems to be no issues and I undid some reverting for 126.

@K4sum1 K4sum1 closed this as completed May 14, 2024
@adeii
Copy link

adeii commented May 15, 2024

You got this! r3dfox 126! Further compatibility for Win 7 than VxKex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants