Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STEMMUS_SCOPE BMI: which variables to expose #209

Open
BSchilperoort opened this issue Nov 17, 2023 · 5 comments
Open

STEMMUS_SCOPE BMI: which variables to expose #209

BSchilperoort opened this issue Nov 17, 2023 · 5 comments
Labels
modflow coupling This issue or pull request already exists

Comments

@BSchilperoort
Copy link
Contributor

BSchilperoort commented Nov 17, 2023

In #208 and EcoExtreML/STEMMUS_SCOPE_Processing#89 I have implemented a BMI for STEMMUS_SCOPE.

For testing purposes I have exposed two variables: the output variable fluxes.Resp and input+output variable TT (soil temperature).

For the implementation of the full BMI we will need to know which variables we want to expose. For these variables we will also need a long or standard name, as well as their unit.

Variables can be an "input variable" an "output variable" or both.

Variable standard name Variable name in code Input/output? Unit Grid
vegetation_respiration fluxes.Resp out ? none
soil_temperature TT in+out degC ModelSettings.mN

@yijianzeng @bobzsu @Yunfei-Wang1993 could you fill in this table for all variables that need to be exposed?

@SarahAlidoost
Copy link
Member

SarahAlidoost commented Nov 20, 2023

@MostafaGomaa93 please see the comment above. Which variables do you need to couple STEMMUS_SCOPE to the groundwater model (MODFLOW 6), please add them to the table above, thanks. relates #205

@MostafaGomaa93
Copy link
Contributor

MostafaGomaa93 commented Nov 20, 2023

@SarahAlidoost. thanks. I am still not yet familiar with the variable names in the code, but I tried my best above. @yijianzeng can confirm the variables I add.

Variable standard name Variable name in code Input/output? Unit Grid
Sum of liquid and vapor water fluxes sum of (QL, Qv, Qa) out kg/m2/s none
Specified matric head at the deepest sublayer (Groundwater head) hN (used when BoundaryCondition.NBChB == 1) in m none

@BSchilperoort
Copy link
Contributor Author

Hi @MostafaGomaa93, I've moved the variables you added to your own comment.

By grid I mean if they are on a certain model grid (for example the soil layers, or fluorescent wavelengths). I think the variables you specify are not on a specific model grid (if they are just one value, not an array).

@MostafaGomaa93
Copy link
Contributor

Hi @BSchilperoort, thanks for your update. Sorry for my misunderstanding of what it means by "Grid". I think indeed the variables I add are one value, not an array.

@yijianzeng
Copy link
Contributor

yijianzeng commented Dec 3, 2023

Variable standard name (refers to ALMA) Variable name in code variable name in equation (add also a link to paper) Input/output? Unit Grid
vegetation_respiration fluxes.Resp out ? none
soil_temperature TT in+out degC ModelSettings.mN
SoilVariables.hh 'hh' in+out mH2O ModelSettings.mN+KT
not_availalbe (leaf water potential) 'PSI' in+out mH2O(need to check) ModelSettings.mN+KT

Before i continue further, these two important soil-plant state varables (soil matric water potential and leaf water potential) are not output with time dimensions?

@Yunfei-Wang1993

@SarahAlidoost SarahAlidoost added the modflow coupling This issue or pull request already exists label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modflow coupling This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants