Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Practical plants default values should be restrictive/null #27

Closed
JustTB opened this issue Dec 20, 2018 · 2 comments
Closed

Practical plants default values should be restrictive/null #27

JustTB opened this issue Dec 20, 2018 · 2 comments

Comments

@JustTB
Copy link
Contributor

JustTB commented Dec 20, 2018

At the moment the default values in practicalplants.js are imho wrong since they lead to wrong information and wrong match making.

I think the default values should be null or empty arrays depending on the format.

@petteripitkanen
Copy link
Collaborator

Yep, defaults (other than nulls or empty arrays) should not be chosen at the data normalization level.

Currently the defaults are chosen for the companionship algorithm to be optimistic when data is missing. If such optimistic behavior is wanted it should be implemented on the level of the companionship algorithm (shared/companionship.js).

@petteripitkanen
Copy link
Collaborator

Fixed by #33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants