Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Crop property matureMeasurementUnit #62

Open
petteripitkanen opened this issue Aug 4, 2019 · 2 comments
Open

Remove Crop property matureMeasurementUnit #62

petteripitkanen opened this issue Aug 4, 2019 · 2 comments

Comments

@petteripitkanen
Copy link
Collaborator

The Crop property matureMeasurementUnit is used for specifying the unit of the properties matureHeight and matureWidth. The unit can currently be either meters or feet. It looks preferable to remove the unit property and convert all values to meters in the preprocessing step in db/practicalplants.js.

@gljivar
Copy link
Contributor

gljivar commented Aug 18, 2019

What would be in that case strategy for usage of the application by people in UK or US?
I have checked and some sources say that in UK there are around 27 million people who partake in gardening which is a big potential user base for the application.

I agree that algorithm should use only one measure, and it should be meters. Maybe then there can be conversion in the UI from meters to feet for these users?

@petteripitkanen
Copy link
Collaborator Author

There could be a test for finding the crops that have values in feet, and for each of these crops the conversion to meters should be asserted. It is probably a good idea to create the conversion function from meters to feet at the same time, and then in this test to also assert the conversion back to feet.

UI could have a preference for displaying either meters or feet. Later there could be a Garden type that contains multiple Bed objects and a geographic location. Maybe the UI could use the geographic location of the Garden objects as a hint when presenting these options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants