Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename create_tinylabel #57

Closed
Pakillo opened this issue Jan 12, 2024 · 4 comments
Closed

Rename create_tinylabel #57

Pakillo opened this issue Jan 12, 2024 · 4 comments

Comments

@Pakillo
Copy link
Member

Pakillo commented Jan 12, 2024

For consistency, it should probably be renamed as create_tiny_label, like the other functions. Before #54

@Pakillo
Copy link
Member Author

Pakillo commented Jan 12, 2024

Actually some functions are "create_certificate_type" but label functions are "create_collection_label" etc. instead of "create_label_type". Probably not necessary to change at this point, but could be changed for consistency

@juliagdealedo
Copy link
Collaborator

You are right, all function names should be changed. However, we have encountered some problems by doing so, we have decided to change it afterwards in an other branch and after the cran check.

@Pakillo
Copy link
Member Author

Pakillo commented Jan 12, 2024

Which problems? Let me know if I can help.
Any function name change should ideally be done before submitting to CRAN, to avoid breaking changes once it's public there

@iramosgutierrez
Copy link
Collaborator

closed in commit d1ce6ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants