Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjs.dev doc site fails to load when an ad blocker is used #134

Open
joelcolucci opened this issue Feb 2, 2021 · 4 comments
Open

adjs.dev doc site fails to load when an ad blocker is used #134

joelcolucci opened this issue Feb 2, 2021 · 4 comments
Assignees

Comments

@joelcolucci
Copy link

joelcolucci commented Feb 2, 2021

Description

Currently the adjs docs website is client-side rendered. Pieces of the page are loaded via XHR/Ajax.
The website fails to load when a user has an ad blocker on. Our current hypothesis is this occurs because the ad blocker see’s “ad” in the URL and blocks the requests assuming it’s ad tracking.

@elengart
Copy link

elengart commented Feb 2, 2021

To reproduce:
flip ad blocker switch and reload
Screen Shot 2021-02-02 at 2 55 23 PM
Screen Shot 2021-02-02 at 2 55 39 PM

@elengart
Copy link

elengart commented Feb 2, 2021

Root cause:
AdBlock uses 'filters' to block ajax requests. Some of these filters are defined here https://easylist.to/
As we see /adjs/*pattern can be found in the primary filter ("easy list"): https://easylist.to/easylist/easylist.txt
Screen Shot 2021-02-02 at 3 24 41 PM

@elengart
Copy link

elengart commented Feb 3, 2021

Proposed solution - migrate from Docsify to Docusaurus
Refs:
https://www.npmjs.com/package/docusaurus
https://www.npmjs.com/package/docusaurus-init

Why Docusaurus?
Docsify’s SSR documentation is sketchy, no demos or showcase SSR examples
Docusaurs is SSR - confirmed
Newer stable product, well documented, react, typescript, webpack...

What’s done

Effort to migrate

  • Integrate with existing codebase - need help
  • Configure sidebar, remove unnecessary navigation, links and pages (unused navs is also issue in the the existing documentation, probably leftovers from demo site)
  • Decorate .md documents with ids and titles

@elengart
Copy link

elengart commented Feb 9, 2021

New findings:

  • Adblocker filters out not just ajax calls, but also all content downloads from a adjs domains. (Confirmed by redirecting localhost to adjs in etc/hosts)
  • Migration to a different document processor will not solve the issue.
  • New proposed solution is to serve docs from CDN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants