Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The allday option is not considered on iOS #514

Open
theblang opened this issue Sep 27, 2019 · 2 comments
Open

The allday option is not considered on iOS #514

theblang opened this issue Sep 27, 2019 · 2 comments

Comments

@theblang
Copy link

I see here that the allday option is checked before deciding to dynamically compute it. But if I check the analogous iOS code, it does not seem to make the same check. Is there a particular reason for this, or would you like a PR to fix this?

@theblang theblang changed the title The allday option works on Android but not iOS The allday option is not considered on iOS Sep 27, 2019
@EddyVerbruggen
Copy link
Owner

I’m not entirely sure what that change would be so I’d gladly review and merge it. Cheers!

@theblang
Copy link
Author

@EddyVerbruggen I assume it would just be checking for that allday option being passed in explicitly, and only dynamically calculating if it isn't. That is what the Android Java code looks to be doing.

On a somewhat related side note, is the logic to calculate allday actually correct? I noticed when testing an event that spanned multiple days, but happened to start and end on the same day, that allday would be calculated to true, and thus the time information would get messed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants