Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uniform data #4

Merged
merged 5 commits into from
Mar 5, 2018
Merged

fix: uniform data #4

merged 5 commits into from
Mar 5, 2018

Conversation

danielgek
Copy link
Contributor

@danielgek danielgek commented Nov 29, 2017

@filipemendes1994 don't merge yet!
i will ping you when i'm done

@inesarmadabras
Copy link
Collaborator

inesarmadabras commented Dec 18, 2017

@danielgek, ping?

- ios is implemented but not tested
- android is Wip
@danielgek
Copy link
Contributor Author

danielgek commented Dec 18, 2017

Yes xD, haven't been able to finish this, ios i think is done, but android is taking a bit longer

@EddyVerbruggen
Copy link
Member

Hey @danielgek you changes align pretty much with what I need for a project, so is there anything I can do to help pushing this forward?

@danielgek
Copy link
Contributor Author

@EddyVerbruggen i think the ios part needs testing but should be good to go, unfortunally i don't have the time to finish this pr and implement the android side, but you can grab all my changes and finish it ;) if you need some help on anything just ping me ;)

@EddyVerbruggen
Copy link
Member

Thanks for the update! I'll consider my options. Cheers! 👍

@EddyVerbruggen EddyVerbruggen merged commit fb31a09 into nativescript-community:master Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants