Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Version control firebase add-on services configuration? #110

Closed
acramatte opened this issue Aug 22, 2016 · 2 comments
Closed

Version control firebase add-on services configuration? #110

acramatte opened this issue Aug 22, 2016 · 2 comments
Milestone

Comments

@acramatte
Copy link

Hi,

I might be missing something but if I understand correctly, the Android's Gradle file and iOS' Podfile are created and configured during the npm postinstall step.

I find this a bit annoying for the two following reasons:

  1. Everyone in the team who installs the project will be prompted for configuring the firebase plugin.
  2. A CI build would also be prompted.

Wouldn't there be a way to have a configuration file that could be added to a version control system and the npm postinstall script would first try to read that config file and do the prompting only if it does not already exist ?

@acramatte acramatte changed the title version control firebase add-on services ? Version control firebase add-on services ? Aug 22, 2016
@acramatte acramatte changed the title Version control firebase add-on services ? Version control firebase add-on services configuration? Aug 22, 2016
@EddyVerbruggen
Copy link
Owner

Sounds useful.. perhaps we can copy it to App_Resources and use that if it exists. BUT what if the install script changes? Then we need to detect that and rerun it (and write it to App_Resources again).

I'm sure that can be automated but let's first discuss this a little. Pinging @sean-perkins since he's the hero that added the script.

@EddyVerbruggen
Copy link
Owner

Automated this in 3.8.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants