This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
added a toValue function that handles primitive types on android #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelagm
changed the title
|
I must admit I didn't test this case, so thank you very much for adding this fix @samuelagm! |
|
Don't mention. Regards. On Oct 9, 2016 4:33 PM, "Eddy Verbruggen" notifications@github.com wrote:
|
EddyVerbruggen
added a commit
that referenced
this pull request
Apr 18, 2017
added a toValue function that handles primitive types on android
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javascript implementation of firebase.push/setValue on android has issues with primitive types; strings are stored in firebase db as an array of characters, booleans don't get to firebase db at all, e.t.c. This is as a result of toHashMap being called on values passed to .push and .setValue regardless of their type.
I've added the ability to handle them.