Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab in Channel Selector is too small to access with touch in 320x480 screen orientation #2412

Closed
1 task done
Tracked by #2363
richardclli opened this issue Sep 29, 2022 · 17 comments · Fixed by #2435
Closed
1 task done
Tracked by #2363
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Milestone

Comments

@richardclli
Copy link
Collaborator

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

  1. Tab size too small
  2. The chooser is align too left

Expected Behavior

  1. Enlarge the tab size for this screen DPI/orientation
  2. At least center the chooser in the screen.

Steps To Reproduce

  1. Add a value widget
  2. Tap the source
  3. Can see the channel chooser popup

Version

Nightly (Please give date/commit below)

Transmitter

FlySky NV14

Anything else?

IMG 018

@richardclli richardclli added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Sep 29, 2022
@pfeerick pfeerick changed the title Tab in Channel Selector is too small to acces with touch in 320x480 screen orientation Tab in Channel Selector is too small to access with touch in 320x480 screen orientation Sep 29, 2022
@pfeerick pfeerick added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour and removed triage Bug report awaiting review / sorting labels Sep 29, 2022
@pfeerick pfeerick added this to the 2.8 milestone Sep 29, 2022
@pfeerick
Copy link
Member

pfeerick commented Sep 29, 2022

Doesn't even need to be the value widget.. just go in to model settings, mix, pick a mix line and hit source. For comparison, here's the TX16S - so if we wanted be real pedantic it's not centered either, but nowhere near as bad as the NV14/EL18 is.
image

@richardclli
Copy link
Collaborator Author

Interesting that TX16S is centered align but EL18 is not.

@Eldenroot
Copy link
Contributor

This popup should be bigger, wasted space around

@gagarinlg
Copy link
Member

This is two pop ups draw next to each other. The first one is the input list and the second one the filter selector. The input list is centered and then the filter selector is drawn next to it

@gagarinlg
Copy link
Member

The pop up will be centered correctly soon, maybe the next nightly.
There is not much that we can do regarding the size of the filter buttons. We do not have those in a larger font currently. Also the next font step would be 24 instead of 16, which seems to be rather large for that application.

@Eldenroot
Copy link
Contributor

What about make a popup wider to make empty space smaller

@Eldenroot
Copy link
Contributor

Also one idea ia to move the category buttons on the top instead on the left, then you can use bigger icons

@gagarinlg
Copy link
Member

What about make a popup wider to make empty space smaller

On the vertically oriented screens, there is not much empty space and if we make it wider on the horizontal screens, you would gain nothing, except having more white

Also one idea ia to move the category buttons on the top instead on the left, then you can use bigger icons

They were on the left originally and I am not going to change that now.
The problem is the fimrware size increase when using bigger symbols. To have the symbols also in the 24pt font costs us about 1800 bytes of flash memory.
@raphaelcoeffic what do you think? It does look much better on the NV14 with the larger fonts, but...
grafik
grafik

@gagarinlg
Copy link
Member

grafik

I generally like the look with the larger symbols.

@Eldenroot
Copy link
Contributor

Bigger icons look nice! +1

@pfeerick
Copy link
Member

pfeerick commented Oct 1, 2022

Bigger are better fore sure, and I don't think the increased flash usage is an issue.

@raphaelcoeffic
Copy link
Member

@gagarinlg you might think about adding some border pixels as well, which makes the contact surface bigger and less erratic with touch.

@gagarinlg
Copy link
Member

gagarinlg commented Oct 1, 2022

grafik
grafik

Like that?
That padding at the right side is my fault :(

@pfeerick
Copy link
Member

pfeerick commented Oct 1, 2022

Is it possible to tweak a little bit more of a gap between the icons - i.e. a little vertical padding between each?

@gagarinlg
Copy link
Member

Just the filter icons or also the menu entries?

@pfeerick
Copy link
Member

pfeerick commented Oct 1, 2022

I think the menu entry size is fine... it's the icons that are a bit... touchy ... but maybe it'll be ok with those larger icons anyway...

@gagarinlg
Copy link
Member

those are the larger icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants