Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper update #9

Merged
merged 3 commits into from Nov 2, 2022
Merged

Wrapper update #9

merged 3 commits into from Nov 2, 2022

Conversation

theskyblockman
Copy link
Contributor

Hello,
This little pull request is to update the dependencies and to make the code more simple to use; by example there is a new field in some entities to know if the object has all it's content loaded from the ENT. I also fixed a bug where if a post on any ENT is any other type than a "actualite" the URL to fetch it's content is different. This is why the wrapper now use the "type" field to know what will be the URL to fetch for the post.

Copy link
Member

@Freezman31 Freezman31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good pr !

lib/src/client.dart Show resolved Hide resolved
lib/src/entities/email.dart Outdated Show resolved Hide resolved
lib/src/entities/homework.dart Outdated Show resolved Hide resolved
Copy link
Member

@Freezman31 Freezman31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !
Did you test it ?

@theskyblockman
Copy link
Contributor Author

theskyblockman commented Nov 1, 2022

Yes I tried it with a local server which reproduce the requests and all seems good

@Freezman31 Freezman31 merged commit 716d968 into EduWireApps:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants