Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include result object in generateStatement function #6

Open
rpc5102 opened this issue Sep 16, 2020 · 1 comment
Open

Include result object in generateStatement function #6

rpc5102 opened this issue Sep 16, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@rpc5102
Copy link
Member

rpc5102 commented Sep 16, 2020

The result object is missing from generateStatement.

generateStatement(
  session,
  verb = NA,
  object = NA,
  description = NA,
  interactionType = NA,
  response = NULL,
  success = NA,
  completion = NA,
  extensions = NULL
)
@rpc5102 rpc5102 added the bug Something isn't working label Sep 16, 2020
@rpc5102 rpc5102 self-assigned this Sep 16, 2020
@rpc5102
Copy link
Member Author

rpc5102 commented Sep 22, 2020

Not sure what I was thinking here, we already have response, success, and completion which go in the result object. We'd just need to add score and duration.

Extensions can go in object, context (not supported), or result so naming should be more clear. Alternatively, accept both types, and add an identifier inside the argument; convert default to list() from NA.

extensions = list(
  list(type = "object", ref = "<link>", value = "<string>"),
  list(type = "result", ref = "<link>", value = "<string>"),
  list(type = "result", ref = "<link>", value = "<string>")
)

@rpc5102 rpc5102 added enhancement New feature or request and removed bug Something isn't working labels Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant