Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify parameter grids to be dictionaries instead of lists of dictionaries #618

Closed
desilinguist opened this issue Jun 4, 2020 · 0 comments · Fixed by #619
Closed

Simplify parameter grids to be dictionaries instead of lists of dictionaries #618

desilinguist opened this issue Jun 4, 2020 · 0 comments · Fixed by #619
Assignees
Milestone

Comments

@desilinguist
Copy link
Member

desilinguist commented Jun 4, 2020

Right now, we always use a list with a single dictionary to represent the default parameter grid for a learner. However, GridSearchCV can take a plain dictionary as well. Given that we almost never search multiple grids, switching to a plain dictionary will make things a lot simpler when implementing voting and stacking learners.

@desilinguist desilinguist changed the title Simplify parameter grids to be dictioanries instead of lists of dictionaries Simplify parameter grids to be dictionaries instead of lists of dictionaries Jun 4, 2020
@desilinguist desilinguist self-assigned this Jun 4, 2020
@desilinguist desilinguist added this to the v2.5 milestone Jun 4, 2020
@desilinguist desilinguist added this to To do in SKLL Release v2.5 Jun 4, 2020
@desilinguist desilinguist moved this from To do to In progress in SKLL Release v2.5 Jun 4, 2020
SKLL Release v2.5 automation moved this from In progress to Done Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant