Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If in-reply-to is not on a post, but an in-reply-to tag exists in the post, add that to the post’s in-reply-to property #91

Closed
EdwardHinkle opened this issue Jan 31, 2018 · 3 comments
Closed

If in-reply-to is not on a post, but an in-reply-to tag exists in the post, add that to the post’s in-reply-to property #91

EdwardHinkle opened this issue Jan 31, 2018 · 3 comments
Assignees
@EdwardHinkle
Labels
enhancement Reader

Comments

@EdwardHinkle
Copy link
Collaborator

Like #89
@EdwardHinkle EdwardHinkle self-assigned this Jan 31, 2018
@EdwardHinkle EdwardHinkle changed the title If in-reply-to is not on a post, but an in-reply-to tag exists in the post, add that to the posts photo property If in-reply-to is not on a post, but an in-reply-to tag exists in the post, add that to the post’s in-reply-to property Jan 31, 2018
@aaronpk
Copy link

aaronpk commented Jan 31, 2018

Did you find an instance of this? This shouldn't happen by definition, since any in-reply-to Microformats property in the post would cause it to appear in the Microsub post. This is in contrast to photos, where an img tag can exist in the content that does not have u-photo so does not get set as the photo property of the Microsub post

@EdwardHinkle
Copy link
Collaborator Author

I have not seen an instance of this. Good to know that this might not be an issue. My main concern was micro.blog posts coming from an RSS feed. I’ll take a closer look to verify everything is as you said and close this if that’s the case.

@EdwardHinkle
Copy link
Collaborator Author

Gotcha, this is correct. This is not an issue. Unfortunately, micro.blog posts in the feed don't have any connection to the post that they are a reply to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EdwardHinkle EdwardHinkle

Labels
enhancement Reader
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronpk @EdwardHinkle