Ts/implement flexbox grid #21
Conversation
|
Also, disregard this PR. I need to address the footer's |
|
The footer issue should be resolved now. This footer will always be positioned at the bottom of the page, but not fixed. Let me know if it looks good to you? |
|
|
||
| <div class="row"><h2 class="col-lg-4">What is this?</h2></div> | ||
|
|
||
| <div class="row"><p class="col-lg-6">It would make sense to introduce in this body of text what this is and how to get started. The rest of this text is lorem ipsum suspendisse ante urna, condimentum vel diam eget, condimentum convallis elit. Maecenas congue enim quis tincidunt fermentum. Sed sit amet neque sapien. Donec ac nunc tincidunt, sodales dolor sit amet, egestas diam. |
There was a problem hiding this comment.
@timsully What do you think we should say on the homepage that isn't said on the into slide/step?
| position: absolute; | ||
| right: 0; | ||
| bottom: 0; | ||
| left: 0; |
There was a problem hiding this comment.
@timsully These 4 pin the footer to the bottom of the visible page. But on mobile/narrow screens, our content fills their screen vertically. Therefore, pinning the footer to the bottom of the visible page results in the footer visually overlapping with our page content.
I'm for just keeping the footer where it was! If the page content is short enough then the footer will be above the fold, otherwise not, which is all good IMO 🙂 .
| -ms-flex-preferred-size: 20%; | ||
| flex-basis: 20%; | ||
| max-width: 20%; | ||
| } |
There was a problem hiding this comment.
@timsully Tell you editor to always add a newline, please.
|
|
||
| <Link to="/step/intro"> | ||
| <button class="primary hvr-ripple-out">Get Started</button> |
There was a problem hiding this comment.
@timsully I'd put this <Link> in the same container as the text above so that its left edge is always aligned. Right now this button is aligned on large screens, then is indented too far (around 1000px, maybe?), then isn't indented enough (below around 640px or 767px?).
This PR adds a flexbox grid layout globally. Not entirely sure if this will impact anything negatively since we haven't had a grid yet? You can see me using the grid in the home page vaguely.
Addressing Issue #20