Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem uploading a new rule. #481

Closed
McMagellan opened this issue May 4, 2024 · 10 comments
Closed

Problem uploading a new rule. #481

McMagellan opened this issue May 4, 2024 · 10 comments

Comments

@McMagellan
Copy link

Sometimes it happens that I cannot upload a rule.
The Rules window freezes. Apparently the routine cannot find the correct end of the file and the console then shows a message like this:

Sat May 4 09:29:31 2024 (329783): Reaching end of read. Readlen: 473, Totallen: 533

An excerpt from the console log shows the following:
Bild 2024-05-04 15_27_02

I have a permanent problem with this attached file.
concat Testrule V1.txt

If I change the length of the rule by inserting lines, the upload works.
This rule only runs on the current beta version #485 (thanks to Igor and CurlyMoo) and includes the new commands @SetCurves, concat and print. The upload process also fails, for example in older versions like 3.2.3 .
.
.
.
.
In addition, I sometimes have the problem that with a longer rule the upload process is aborted with the following message: Too large read. (see middle of picture)
IMG_7679

@IgorYbema
Copy link
Contributor

Yes there is a bug which causes it to not read it when it is a specific length. This bug is fixed but not made to production yet.

@McMagellan
Copy link
Author

Thanks for the quick reply. This error has been bothering me for a long time. Good to hear that a fix is ​​coming. Igor asked me not to post any unrelated topics in the "Update rule library" thread, which is why I'm putting it here and hope it's in the right place.

@IgorYbema
Copy link
Contributor

That was CurlyMo asking you that, not me :)

@IgorYbema
Copy link
Contributor

Wait, I didn't read it correctly. You also get the error on the alpha builds? I just tried and indeed the webloading seems to hang using this ruleset.

@McMagellan
Copy link
Author

I'm currently using version Alpha-8aa33db, #485
I just wrote a long-term test program with concat, print and SetCurves with and without numeric values and got the “Too large read” error when uploading. Added two blank lines at the end and it can be loaded. Both loading errors in #485 have definitely not been eliminated.

IMG_8346

@IgorYbema
Copy link
Contributor

IgorYbema commented May 5, 2024

I believe I found it. Took me a few hours. Can you test it?
IgorYbema#121 (comment)

And can you share that long rules which causes the 'too long read'? Maybe it is fixed now also, not sure.

@McMagellan
Copy link
Author

I switched to version Alpha-f9b90fd #487.
now you have to be strong. Unfortunately, during the first test as described above, I had the same error as described above. After rebooting and reopening the window and saving with an empty window, the next attempt to load the rule worked. Several subsequent loading processes went smoothly.
The error can therefore only be reproduced by chance and is probably dependent on the state of the Heishamon internal memory usage.

You asked about the test rule that yesterday said "Too large read!" caused.
After a 20-hour test operation, I reloaded the rule today in the old firmware status #485 and the error no longer occurred and can therefore not be reliably reproduced.
You can see that he was there yesterday in the picture above at the time stamp, May 4th 4:11 p.m.

Attached is the test rule. Again, I think it depends on Heishamon's current internal memory state.

concat Testrule V2a.txt

@IgorYbema
Copy link
Contributor

Ok thanks. Yes I believe that there is still another bug in there which is hard to reproduce but this is much better already.

@McMagellan
Copy link
Author

Today I had the error again when loading a test rule with "Too large read" in version Alpha-afd39aa, #494.
After I reopened the crashed rules window and reloaded the same rule, it worked. this error cannot be reproduced.

IMG_8361

@CurlyMoo
Copy link
Contributor

This issue seems to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants