Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

(feature-request): Add ability to configure all YT Video Options #23

Closed
AdlerJS opened this issue Sep 2, 2021 · 5 comments
Closed

(feature-request): Add ability to configure all YT Video Options #23

AdlerJS opened this issue Sep 2, 2021 · 5 comments
Labels
help wanted A new feature, enhancement, or improvement ios Relates to the iOS Platform

Comments

@AdlerJS
Copy link
Contributor

AdlerJS commented Sep 2, 2021

Feature request

@EinfachHans our QA found a bug where they were trying to upload / pick videos longer than 60 seconds but still under our 150 MB limit. The YT package on IOS gives the error "Pick a Video that is less than 60.0 seconds long" via a popup. After doing some research it seems this is the default setting for the config.video. I see we have an option to override compression just wondering the effort to get the following added to be able to override all video options as shown below

config.video.compression = AVAssetExportPresetHighestQuality
config.video.fileType = .mov
config.video.recordingTimeLimit = 60.0
config.video.libraryTimeLimit = 60.0
config.video.minimumTimeLimit = 3.0
config.video.trimmerMaxDuration = 60.0
config.video.trimmerMinDuration = 3.0
@AdlerJS AdlerJS added the triage label Sep 2, 2021
@EinfachHans
Copy link
Owner

PR's are highly welcome

@EinfachHans EinfachHans added help wanted A new feature, enhancement, or improvement ios Relates to the iOS Platform and removed triage labels Sep 13, 2021
@AdlerJS
Copy link
Contributor Author

AdlerJS commented Sep 30, 2021

@EinfachHans finally got around to creating the PR / writing the code for this. But do not have write access even on a separate branch on this repo. Is it possible to add me to avoid having to create a fork. Thanks!

@EinfachHans
Copy link
Owner

@danbunkr pls create a Fork, you can delete the forked repository after the PR is merged 😊

@AdlerJS
Copy link
Contributor Author

AdlerJS commented Oct 8, 2021

See: #24

@EinfachHans
Copy link
Owner

EinfachHans commented Oct 10, 2021

Thanks for your PR. 😊 This is released in 1.5.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted A new feature, enhancement, or improvement ios Relates to the iOS Platform
Projects
None yet
Development

No branches or pull requests

2 participants