(feature-request): Make PacketsReceiptNotificationsValue configurable

[alfabetagama]

PacketsReceiptNotificationsValue is currently hardcoded at 10 in:

cordova-plugin-dfu-update/src/android/DfuUpdate.java

Line 111 in 931d297

.setPacketsReceiptNotificationsValue(10)

and

cordova-plugin-dfu-update/src/ios/DfuUpdate.swift

Line 101 in 931d297

initiator.packetReceiptNotificationParameter = 10

We have some devices that need this set to 1, so we propose that PacketsReceiptNotificationsValue is set via:

cordova-plugin-dfu-update/src/ionic/index.js

Line 8 in 931d297

DfuUpdate.updateFirmware = function (resultCallback, errorCallback, fileURL, deviceIdentifier) {

as additional parameter:

DfuUpdate.updateFirmware = function (resultCallback, errorCallback, fileURL, deviceIdentifier, packetReceiptNotificationsValue)

[EinfachHans]

Can you explain me more about what this Parameter means? I developed/forked this Plugin to work with our current environment and want to understand this change

[alfabetagama]

Thanks for quick response. Here is link to documentation:

https://infocenter.nordicsemi.com/index.jsp?topic=%2Fcom.nordic.infocenter.sdk5.v11.0.0%2Fbledfu_transport_bleservice.html

And description:

Number of PacketsInformation: Parameter value for the Packet Receipt Notification Request Op Code	C1	uint16	Number of packets of firmware data to be received by the DFU target before sending a new Packet Receipt Notification (control point notification with Op Code = 7). If this value is 0, the packet receipt notification will be disabled by the DFU target.

[EinfachHans]

Ok thank you. I will look into this and release a update the next days!

[alfabetagama]

@EinfachHans thanks, looking forward to it.

[EinfachHans]

Just released Version 1.3.0, which includes the availability to set an extra Option: packetReceiptNotificationsValue
Please notice that this is a Breaking Change as the Options are now all included into a JSON (See Usage)

Thanks for using 😊 If you have time would be great if you can like my PR to Include a Ionic Wrapper for this Plugin here

[alfabetagama]

Thanks. Great work! I will try to test it on android today.