Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for enhanced features #4

Closed
GitPetri opened this issue Aug 30, 2021 · 7 comments
Closed

Proposal for enhanced features #4

GitPetri opened this issue Aug 30, 2021 · 7 comments
Labels
discussion Ticket containing mostly discussions

Comments

@GitPetri
Copy link

GitPetri commented Aug 30, 2021

Thank you for the good work creating this integration.
Looking at this integration after installation and Vacuum card I couldn't make the following to work, might just be stupid me but if these are not implemented please do consider the following:

  • Cleaning area
  • Cleaning time
  • Maps/zones

Looking at the Android Wellbeing app and this issue, the data probably is available via the API.

@Ekman
Copy link
Owner

Ekman commented Aug 30, 2021

It's always appreciating when people are using your own software 🙇

That card looks awesome! I'll try and fiddle a little bit with it as well. However, the integration currently does not report any attributes, which that card is using to display various stats. As soon as I'm confident that the current code is stable, I'll start looking at adding some attributes.

Also, I'd like to look at adding map functionality. According to the Home Assistant documentation, a vacuum is able to report SUPPORT_MAP as a feature, but I haven't been able to find any documentation on how. Help finding the proper documentation or reference implementation is much appreciated.

@Ekman Ekman added enhancement New feature or request help wanted Extra attention is needed labels Aug 30, 2021
@GitPetri
Copy link
Author

GitPetri commented Aug 30, 2021

There is at least this having links for map fetch for Xiaomi, Rockrobo and https://github.com/PiotrMachowski/Home-Assistant-custom-components-Xiaomi-Cloud-Map-Extractor
Edit: some of those seem to be valid for rooted vacuums thus taking the maps directly from the vacuum instead from cloud. https://github.com/PiotrMachowski/Home-Assistant-custom-components-Xiaomi-Cloud-Map-Extractor/blob/master/scripts/get_map.py. Probably not easy as I thought.

@GitPetri
Copy link
Author

@drgreenbaum
Copy link

Hi! Great work! Can you add the option to do a spot cleaning too? Seems to be implemented in Home Assistant!

@Ekman Ekman added discussion Ticket containing mostly discussions and removed enhancement New feature or request labels Aug 31, 2021
@Ekman
Copy link
Owner

Ekman commented Aug 31, 2021

Thank you @drgreenbaum . I'll see what I can do but it'll be a while before I get there.

@Ekman
Copy link
Owner

Ekman commented Aug 31, 2021

Thank you @GitPetri for the links. I think I've managed to figure out how maps works in Home Assistant now. Now I just need to try it out and fiddle with it.

@Ekman Ekman removed the help wanted Extra attention is needed label Aug 31, 2021
@Ekman
Copy link
Owner

Ekman commented Sep 9, 2021

I've created separate issues for each request.

@Ekman Ekman closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Ticket containing mostly discussions
Projects
None yet
Development

No branches or pull requests

3 participants