Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds explicit linking of serial library to motor_driver_demo app. #157

Merged
merged 1 commit into from Sep 28, 2023
Merged

Adds explicit linking of serial library to motor_driver_demo app. #157

merged 1 commit into from Sep 28, 2023

Conversation

francocipollone
Copy link
Collaborator

🦟 Bug fix

Fixes #

Summary

Alternatives

  • Creating a pimpl pattern for the MotorDriver class to hide the header file into the implementation would be neat.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone
Adds explicit linking of serial library to motor_driver_demo app.
377ae8f 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone mentioned this pull request Sep 28, 2023
Closed
6 tasks
@francocipollone francocipollone merged commit 66fd464 into humble Sep 28, 2023
3 checks passed
@francocipollone francocipollone deleted the francocipollone/adds_explicit_linking branch September 28, 2023 13:03
@francocipollone francocipollone mentioned this pull request Oct 3, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jballoffet jballoffet jballoffet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Andino Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francocipollone @jballoffet