Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup basic infrastructure and CI pipeline #1

Merged
merged 10 commits into from
Oct 25, 2022
Merged

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Oct 24, 2022

As the title says, this patch sets up basic infrastructure for the project, including a development docker image and utility scripts (build, test, lint). It also configures a CI pipeline using github actions.

This patch adds a basic dev dockerfile and a tool to bring it up. I also uses fixuid, so files generated in the container will match files in the host.
Adds CMakeLists.txt and a basic directory structure for the project. Fetches googletest and googlebenchmark packages.
Adds a tool to run clang-format and lint files.
@nahueespinosa nahueespinosa mentioned this pull request Oct 24, 2022
@nahueespinosa nahueespinosa changed the title Setup basic infrastructure Setup basic infrastructure and CI pipeline Oct 24, 2022
camistolo
camistolo previously approved these changes Oct 24, 2022
Copy link

@camistolo camistolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some things I'll have to research on my own (it might take me a while), but it looks good overall!

beluga/core/CMakeLists.txt Show resolved Hide resolved
hidmic
hidmic previously approved these changes Oct 24, 2022
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for a few minor comments

docker/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/ci_pipeline.yml Show resolved Hide resolved
tools/dev.sh Show resolved Hide resolved
@nahueespinosa nahueespinosa merged commit f3e9370 into master Oct 25, 2022
@nahueespinosa nahueespinosa deleted the nahuel/infra branch October 25, 2022 02:36
@nahueespinosa nahueespinosa self-assigned this Nov 9, 2022
@nahueespinosa nahueespinosa added the infra Related to infrastructure and CI label Jan 6, 2023
serraramiro1 added a commit that referenced this pull request Apr 10, 2024
Signed-off-by: Ramiro Serra <serraramiro@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Related to infrastructure and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants