-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup basic infrastructure and CI pipeline #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a basic dev dockerfile and a tool to bring it up. I also uses fixuid, so files generated in the container will match files in the host.
Adds CMakeLists.txt and a basic directory structure for the project. Fetches googletest and googlebenchmark packages.
Adds a tool to run clang-format and lint files.
Rename it so it can be found by the linter script.
85e6924
to
01fe2da
Compare
Closed
c0c7cbe
to
6a5f11b
Compare
camistolo
previously approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Some things I'll have to research on my own (it might take me a while), but it looks good overall!
hidmic
previously approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but for a few minor comments
hidmic
approved these changes
Oct 25, 2022
serraramiro1
added a commit
that referenced
this pull request
Apr 10, 2024
Signed-off-by: Ramiro Serra <serraramiro@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this patch sets up basic infrastructure for the project, including a development docker image and utility scripts (build, test, lint). It also configures a CI pipeline using github actions.