Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake8 and pep257 to pre-commit hooks #115

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Add flake8 and pep257 to pre-commit hooks #115

merged 1 commit into from
Feb 14, 2023

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Feb 13, 2023 •
edited
Loading

Fixes #112.

Summary

This patch adds flake8 and pep257 to pre-commit hooks so we can catch formatting errors without running colcon test on the beluga_example package on CI (which would greatly increase our build time).

Checklist

  • Read the contributing guidelines.
  • Configured pre-commit and ran colcon test locally.
  • Signed all commits for DCO.
  • Added tests (regression tests for bugs, coverage of new code for features).
  • Updated documentation (as needed).
  • Checked that CI is passing.

@nahueespinosa
Add flake8 and pep256 to pre-commit hooks
f061faa 
Fixes #112.

This patch adds flake8 and pep257 to pre-commit hooks so we can catch
formatting errors without running colcon test on beluga_amcl on CI.

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added bug Something isn't working enhancement New feature or request infra Related to infrastructure and CI labels Feb 13, 2023
@nahueespinosa nahueespinosa self-assigned this Feb 13, 2023
@nahueespinosa nahueespinosa changed the title Add flake8 and pep256 to pre-commit hooks Add flake8 and pep257 to pre-commit hooks Feb 13, 2023
glpuga
glpuga approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nahueespinosa nahueespinosa merged commit f687c82 into main Feb 14, 2023
@nahueespinosa nahueespinosa deleted the nahuel/add-flake8-pep257-hooks branch February 14, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpuga glpuga glpuga approved these changes

Assignees

@nahueespinosa nahueespinosa

Labels
bug Something isn't working enhancement New feature or request infra Related to infrastructure and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

beluga_example fails to pass tests
2 participants
@nahueespinosa @glpuga